chore: update GitHub Actions workflows for UBI 9 and UBI 10 images#250
chore: update GitHub Actions workflows for UBI 9 and UBI 10 images#250prabhuk25 wants to merge 1 commit intodevfile:mainfrom
Conversation
|
I'm updating a workflow failure snapshot for you to look over. Image publishing is blocked due to a Docker manifest issue. |
|
Hey Team, |
📝 WalkthroughWalkthroughReplaced manual per-arch manifest assembly (inspect/jq/create/annotate/push) with Changes
Sequence Diagram(s)sequenceDiagram
rect rgba(220,240,255,0.5)
participant GH as GitHub Actions Runner
end
rect rgba(255,240,220,0.5)
participant BX as docker buildx / imagetools
end
rect rgba(240,255,220,0.5)
participant REG as Container Registry
end
GH->>REG: push per-arch images (`amd64`, `arm64`, `ppc64le`)
GH->>BX: run `imagetools create -t <multi-tag> <amd64> <arm64> <ppc64le>`
BX->>REG: assemble multi-arch manifest referencing per-arch images
BX-->>GH: return manifest digest / result
GH->>BX: run `imagetools inspect <multi-tag>` (verify)
BX-->>GH: inspection / metadata output
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/ubi10-build.yaml (1)
16-18:⚠️ Potential issue | 🟠 MajorFix the reusable workflow output mapping.
Line 18 references an invalid path. The
publish-udijob exposesuniq_tagdirectly (Line 153), not as a nested property undersetTagName. Callers of this reusable workflow will receive an empty value foruniq_tag.Suggested fix
outputs: uniq_tag: description: "The unique tag for the universal developer image" - value: ${{ jobs.publish-udi.outputs.setTagName.uniq_tag }} + value: ${{ jobs.publish-udi.outputs.uniq_tag }}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/ubi10-build.yaml around lines 16 - 18, The reusable workflow output mapping is using an invalid path; change the mapping for uniq_tag to reference the output exposed by the publish-udi job directly (use jobs.publish-udi.outputs.uniq_tag) instead of the nested setTagName property so callers receive the actual uniq_tag value from the publish-udi job; locate the output mapping that defines uniq_tag and replace the current value expression with the direct jobs.publish-udi.outputs.uniq_tag reference.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In @.github/workflows/ubi10-build.yaml:
- Around line 16-18: The reusable workflow output mapping is using an invalid
path; change the mapping for uniq_tag to reference the output exposed by the
publish-udi job directly (use jobs.publish-udi.outputs.uniq_tag) instead of the
nested setTagName property so callers receive the actual uniq_tag value from the
publish-udi job; locate the output mapping that defines uniq_tag and replace the
current value expression with the direct jobs.publish-udi.outputs.uniq_tag
reference.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 531fb305-7b98-40ae-85ca-5a2b5184e56a
📒 Files selected for processing (5)
.github/workflows/pr-check-ubi10.yaml.github/workflows/pr-check.yaml.github/workflows/ubi10-build.yaml.github/workflows/ubi9-build.yamluniversal/ubi10/Dockerfile
prabhuk25
force-pushed
the
fix/docker-buildx-publish
branch
from
3d417a4 to
9dc300e
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: prabhuk25, rohanKanojia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/pr-check.yaml (1)
163-196: Add post-createimagetools inspectfor parity with the UBI10 workflow.The sibling
pr-check-ubi10.yamlverifies each composed manifest withdocker buildx imagetools inspectright aftercreate(lines 176-177 and 202-203 there), but this file skips that step for bothpublish-base-imageandpublish-udi. Given the whole point of this PR is to recover from manifest publishing failures, keeping an explicit inspect here would surface a bad manifest immediately in logs and keep the two PR-check workflows symmetric.♻️ Suggested change
docker buildx imagetools create \ -t ${{ env.REGISTRY }}/base-developer-image:pr-${{github.event.number}} \ ${{ env.REGISTRY }}/base-developer-image:amd64-pr-${{github.event.number}} \ ${{ env.REGISTRY }}/base-developer-image:arm64-pr-${{github.event.number}} \ ${{ env.REGISTRY }}/base-developer-image:ppc64le-pr-${{github.event.number}} + + docker buildx imagetools inspect \ + ${{ env.REGISTRY }}/base-developer-image:pr-${{github.event.number}}docker buildx imagetools create \ -t ${{ env.REGISTRY }}/universal-developer-image:pr-${{github.event.number}} \ ${{ env.REGISTRY }}/universal-developer-image:amd64-pr-${{github.event.number}} \ ${{ env.REGISTRY }}/universal-developer-image:arm64-pr-${{github.event.number}} \ ${{ env.REGISTRY }}/universal-developer-image:ppc64le-pr-${{github.event.number}} + + docker buildx imagetools inspect \ + ${{ env.REGISTRY }}/universal-developer-image:pr-${{github.event.number}}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/pr-check.yaml around lines 163 - 196, Add a post-create verification step that runs "docker buildx imagetools inspect" for both manifest publishes: after the docker buildx imagetools create in the "Publish UBI9 base image manifest" step (the step named Publish UBI9 base image manifest) and after the create in the "Publish UDI9 manifest" step (the step named Publish UDI9 manifest / job publish-udi); run imagetools inspect against the same manifest tag (e.g., ${{ env.REGISTRY }}/base-developer-image:pr-${{github.event.number}} and ${{ env.REGISTRY }}/universal-developer-image:pr-${{github.event.number}}) to surface composition errors immediately and mirror the parity behavior from pr-check-ubi10.yaml.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/pr-check.yaml:
- Around line 163-196: Add a post-create verification step that runs "docker
buildx imagetools inspect" for both manifest publishes: after the docker buildx
imagetools create in the "Publish UBI9 base image manifest" step (the step named
Publish UBI9 base image manifest) and after the create in the "Publish UDI9
manifest" step (the step named Publish UDI9 manifest / job publish-udi); run
imagetools inspect against the same manifest tag (e.g., ${{ env.REGISTRY
}}/base-developer-image:pr-${{github.event.number}} and ${{ env.REGISTRY
}}/universal-developer-image:pr-${{github.event.number}}) to surface composition
errors immediately and mirror the parity behavior from pr-check-ubi10.yaml.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 25aa5125-63ec-42d8-84d6-5d487ae94bf2
📒 Files selected for processing (5)
.github/workflows/pr-check-ubi10.yaml.github/workflows/pr-check.yaml.github/workflows/ubi10-build.yaml.github/workflows/ubi9-build.yamluniversal/ubi10/Dockerfile
✅ Files skipped from review due to trivial changes (1)
- .github/workflows/ubi9-build.yaml
🚧 Files skipped from review as they are similar to previous changes (2)
- universal/ubi10/Dockerfile
- .github/workflows/ubi10-build.yaml
Signed-off-by: Prabhu K <Prabhu.K@ibm.com>
prabhuk25
force-pushed
the
fix/docker-buildx-publish
branch
from
fc78e73 to
f0055f3
Compare
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
universal/ubi10/Dockerfile (1)
401-415:⚠️ Potential issue | 🟡 MinorApply the same
Linux_aarch64fix touniversal/ubi9/Dockerfile—arm64 builds will fail.
Linux_aarch64is the correct asset suffix for bothtkn_0.20.0_Linux_aarch64.tar.gz(ubi9) andtkn_0.43.0_Linux_aarch64.tar.gz(ubi10). This PR fixes ubi10's arm64 builds at line 406, but ubi9 still incorrectly usesTKN_ARCH="Linux_arm64"at line 370 for the same Tekton CLI asset naming convention. The arm64 build for ubi9 will fail with the same 404 error unless corrected toLinux_aarch64.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@universal/ubi10/Dockerfile` around lines 401 - 415, The ubi9 Dockerfile uses the wrong Tekton asset suffix for arm64; locate the TARGETARCH case block that sets TKN_ARCH (the same pattern as in universal/ubi10/Dockerfile) and change the arm64 branch from TKN_ARCH="Linux_arm64" to TKN_ARCH="Linux_aarch64" so it matches the Tekton release filenames (e.g., tkn_0.20.0_Linux_aarch64.tar.gz); ensure the other branches (amd64, ppc64le, default) remain unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@universal/ubi10/Dockerfile`:
- Around line 401-415: The ubi9 Dockerfile uses the wrong Tekton asset suffix
for arm64; locate the TARGETARCH case block that sets TKN_ARCH (the same pattern
as in universal/ubi10/Dockerfile) and change the arm64 branch from
TKN_ARCH="Linux_arm64" to TKN_ARCH="Linux_aarch64" so it matches the Tekton
release filenames (e.g., tkn_0.20.0_Linux_aarch64.tar.gz); ensure the other
branches (amd64, ppc64le, default) remain unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 4c927e42-33fa-4257-b5c0-4b72cd4e4330
📒 Files selected for processing (5)
.github/workflows/pr-check-ubi10.yaml.github/workflows/pr-check.yaml.github/workflows/ubi10-build.yaml.github/workflows/ubi9-build.yamluniversal/ubi10/Dockerfile
✅ Files skipped from review due to trivial changes (1)
- .github/workflows/ubi9-build.yaml
🚧 Files skipped from review as they are similar to previous changes (2)
- .github/workflows/ubi10-build.yaml
- .github/workflows/pr-check-ubi10.yaml
2 participants
Updated GitHub Actions workflows for UBI 9 and UBI 10 developer images.
Changes include:
Summary by CodeRabbit